linux-kernel - Re: [PATCH 1/2] extcon: Set platform drvdata in gpio_extcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <22448380.601061340101146820.JavaMail.weblogic@epml24>
Date:	Tue, 19 Jun 2012 10:19:07 +0000 (GMT)
From:	함명주 <myungjoo.ham@...sung.com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mike Lockwood <lockwood@...roid.com>,
	"myungjoo.ham@...il.com" <myungjoo.ham@...il.com>
Subject: Re: [PATCH 1/2] extcon: Set platform drvdata in gpio_extcon_probe()
 and fix irq leak

> Add missing platform_set_drvdata() in gpio_extcon_probe(), otherwise calling
> platform_get_drvdata in gpio_extcon_remove() returns NULL.
> 
> Also add missing free_irq call in gpio_extcon_remove().
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Thanks!


Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>

I'll apply this patch to the extcon-for-next.
I would appear in http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next soon after syncing servers.


Cheers!
MyungJoo

> ---
>  drivers/extcon/extcon_gpio.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/extcon/extcon_gpio.c b/drivers/extcon/extcon_gpio.c
> index fe7a07b..8a0dcc1 100644
> --- a/drivers/extcon/extcon_gpio.c
> +++ b/drivers/extcon/extcon_gpio.c
> @@ -125,6 +125,7 @@ static int __devinit gpio_extcon_probe(struct platform_device *pdev)
>  	if (ret < 0)
>  		goto err_request_irq;
>  
> +	platform_set_drvdata(pdev, extcon_data);
>  	/* Perform initial detection */
>  	gpio_extcon_work(&extcon_data->work.work);
>  
> @@ -146,6 +147,7 @@ static int __devexit gpio_extcon_remove(struct platform_device *pdev)
>  	struct gpio_extcon_data *extcon_data = platform_get_drvdata(pdev);
>  
>  	cancel_delayed_work_sync(&extcon_data->work);
> +	free_irq(extcon_data->irq, extcon_data);
>  	gpio_free(extcon_data->gpio);
>  	extcon_dev_unregister(&extcon_data->edev);
>  	devm_kfree(&pdev->dev, extcon_data);
> -- 
> 1.7.9.5
>