linux-kernel - Re: [PATCH] Makefile: fix up CROSS_COMPILE and READABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Jun 2012 21:13:38 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Linux-Next <linux-next@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] Makefile: fix up CROSS_COMPILE and READABLE_ASM
 interaction.

On Tue, Jun 19, 2012 at 11:17:59AM +0200, Geert Uytterhoeven wrote:
> On Mon, Jun 18, 2012 at 6:55 AM, Paul Mundt <lethal@...ux-sh.org> wrote:
> > (Apologies for the re-send, forgot to Cc linux-kernel)
> >
> > When the READABLE_ASM cc-option tests were added they were done so prior
> > to the arch Makefile include, resulting in cc-option being run on the
> > host cc instead of the factoring in the cross prefix set up by the
> > architecture.
> >
> > This bumps the include back up so that cc-option actually runs on the
> > compiler that we're building with.
> 
> I find it a real pity these reported, hard to investigate, and fixed
> build issues keep
> flowing into mainline, without the corresponding fix...
> 
> https://lkml.org/lkml/2012/5/12/36
> 
Agreed. These one-off things are always a nuisance, and often fall
through the cracks. I've yet to find a good solution for them, although
having them rolled in to -next helps.

In this case I got bit by -fno-partial-inlining instead, and since you
didn't have READABLE_ASM in the subject I missed your patch entirely. In
retrospect I should have searched for cc-option. At least we've now both
scratched our heads and come up with an identical fix independently,
which counts a lot more than a Tested-by ;-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/