linux-kernel - Re: [PATCH 02.5] mm: sl[au]b: first remove PFMEMALLOC flag then SLAB flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120620073805.GD8810@suse.de>
Date:	Wed, 20 Jun 2012 08:38:05 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux-MM <linux-mm@...ck.org>,
	Linux-Netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>, Neil Brown <neilb@...e.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mike Christie <michaelc@...wisc.edu>,
	Eric B Munson <emunson@...bm.net>
Subject: Re: [PATCH 02.5] mm: sl[au]b: first remove PFMEMALLOC flag then SLAB
 flag

On Fri, Jun 15, 2012 at 05:54:32PM +0200, Sebastian Andrzej Siewior wrote:
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> 
> If we first remove the SLAB flag followed by the PFMEMALLOC flag then the
> removal of the latter will trigger the VM_BUG_ON() as it can be seen in
> | kernel BUG at include/linux/page-flags.h:474!
> | invalid opcode: 0000 [#1] PREEMPT SMP
> | Call Trace:
> |  [<c10e2d77>] slab_destroy+0x27/0x70
> |  [<c10e3285>] drain_freelist+0x55/0x90
> |  [<c10e344e>] __cache_shrink+0x6e/0x90
> |  [<c14e3211>] ? acpi_sleep_init+0xcf/0xcf
> |  [<c10e349d>] kmem_cache_shrink+0x2d/0x40
> 
> because the SLAB flag is gone. This patch simply changes the order.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Grr, yes of course. Thanks very much. I've folded this into patch 2 and
preserved credit.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/