linux-kernel - Re: [PATCH] regulator: arizona: Add support for microphone supplies on Arizona devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120620114840.GL3978@opensource.wolfsonmicro.com>
Date:	Wed, 20 Jun 2012 12:48:40 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: arizona: Add support for microphone supplies
 on Arizona devices

On Wed, Jun 20, 2012 at 07:32:18PM +0800, Axel Lin wrote:

> I think you may want to put this Kconfig entriy along with other
> Wolfson Microelectronics chips. So all Wolfson chips show in a group.

I'd rather keep the Kconfig entries sorted alphabetically.

> BTW, seems the MFD_ARIZONA patchs are not (yet) available in LKML.

Surprisingly I am aware of that...

> > +       if (selector < 0)
> > +               return -EINVAL;

> I think you don't need this checking. You already ensure min_uV >= 1700000.

No harm in being paranoid.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)