linux-kernel - Re: [PATCH] Docs: printk-formats: add description for %pMR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120620141957.d865133a.akpm@linux-foundation.org>
Date:	Wed, 20 Jun 2012 14:19:57 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andrei Emeltchenko <Andrei.Emeltchenko.news@...il.com>
Cc:	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH] Docs: printk-formats: add description for %pMR

On Wed, 20 Jun 2012 13:44:49 +0300
Andrei Emeltchenko <Andrei.Emeltchenko.news@...il.com> wrote:

> From: Andrei Emeltchenko <andrei.emeltchenko@...el.com>
> 
> Add information about new specifier %pMR for Bluetooth addresses.
> 
> ...
>
> --- a/Documentation/printk-formats.txt
> +++ b/Documentation/printk-formats.txt
> @@ -56,6 +56,7 @@ Struct Resources:
>  MAC/FDDI addresses:
>  
>  	%pM	00:01:02:03:04:05
> +	%pMR	05:04:03:02:01:00
>  	%pMF	00-01-02-03-04-05
>  	%pm	000102030405
>  
> @@ -67,6 +68,10 @@ MAC/FDDI addresses:
>  	the 'M' specifier to use dash ('-') separators instead of the default
>  	separator.
>  
> +	For Bluetooth addresses the 'R' specifier shall be used after the 'M'
> +	specifier to use reversed byte order suitable for visual interpretation
> +	of Bluetooth addresses which are in the little endian order.
> +

huh, I didn't know about that file, or I forgot about it.  I wonder if
it is otherwise up to date.

Do we really need it?  If we can sufficiently document the printk
formats in lib/vsprintf.c then let's remove
Documentation/printk-formats.txt.  Otherwise, I shall do this:


--- a/lib/vsprintf.c
+++ a/lib/vsprintf.c
@@ -1297,6 +1297,8 @@ qualifier:
  *   case.
  * %n is ignored
  *
+ * ** Please update Documentation/printk-formats.txt when making changes **
+ *
  * The return value is the number of characters which would
  * be generated for the given input, excluding the trailing
  * '\0', as per ISO C99. If you want to have the exact
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/