linux-kernel - Re: [PATCH -v6 3/4] PCI, PM, Do not call pci_set_power_state with PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201206210047.57882.rjw@sisk.pl>
Date:	Thu, 21 Jun 2012 00:47:57 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Huang Ying <ying.huang@...el.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>, ming.m.lin@...el.com,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-pm@...r.kernel.org, Zheng Yan <zheng.z.yan@...el.com>,
	Michal Miroslaw <mirq-linux@...e.qmqm.pl>,
	Jesse Barnes <jesse.barnes@...el.com>
Subject: Re: [PATCH -v6 3/4] PCI, PM, Do not call pci_set_power_state with PCI_D3cold

On Tuesday, June 19, 2012, Huang Ying wrote:
> PCI subsystem has not been ready for D3cold support yet.  So
> PCI_D3cold should not be used as parameter for pci_set_power_state.
> This patch is needed for upcoming PCI_D3cold support.
> 
> This patch has no functionality change, because pci_set_power_state
> will bound the parameter to PCI_D3hot too.
> 
> Cc: Michal Miroslaw <mirq-linux@...e.qmqm.pl>
> Cc: Jesse Barnes <jesse.barnes@...el.com>
> Signed-off-by: Huang Ying <ying.huang@...el.com>

Reviewed-by: Rafael J. Wysocki <rjw@...k.pl>

> ---
>  arch/x86/pci/mrst.c       |    2 +-
>  drivers/misc/cb710/core.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/x86/pci/mrst.c
> +++ b/arch/x86/pci/mrst.c
> @@ -264,7 +264,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
>  
>  static void __devinit mrst_power_off_unused_dev(struct pci_dev *dev)
>  {
> -	pci_set_power_state(dev, PCI_D3cold);
> +	pci_set_power_state(dev, PCI_D3hot);
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0801, mrst_power_off_unused_dev);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0809, mrst_power_off_unused_dev);
> --- a/drivers/misc/cb710/core.c
> +++ b/drivers/misc/cb710/core.c
> @@ -180,7 +180,7 @@ static int cb710_suspend(struct pci_dev
>  	pci_save_state(pdev);
>  	pci_disable_device(pdev);
>  	if (state.event & PM_EVENT_SLEEP)
> -		pci_set_power_state(pdev, PCI_D3cold);
> +		pci_set_power_state(pdev, PCI_D3hot);
>  	return 0;
>  }
>  
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/