linux-kernel - Re: [PATCH V2 1/3] staging/rtl8192u: fix coding style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jun 2012 16:08:39 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Devendra Naga <devendra.aaru@...il.com>
Cc:	"Justin P. Mattock" <justinmattock@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/3] staging/rtl8192u: fix coding style problems

On Wed, Jun 20, 2012 at 12:35:42AM +0530, Devendra Naga wrote:
> fixed some of the coding style problems reported by checkpatch
> 
> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
> ---
>  drivers/staging/rtl8192u/r8180_93cx6.c |   36 +++++++++++++++++---------------
>  1 file changed, 19 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/staging/rtl8192u/r8180_93cx6.c
> index 3c515b7..19f5270 100644
> --- a/drivers/staging/rtl8192u/r8180_93cx6.c
> +++ b/drivers/staging/rtl8192u/r8180_93cx6.c
> @@ -22,13 +22,16 @@
>  
>  void eprom_cs(struct net_device *dev, short bit)
>  {
> -	if(bit)
> +	if (bit) {
> +		/* enable EPROM */
>  		write_nic_byte_E(dev, EPROM_CMD,
> -			       (1<<EPROM_CS_SHIFT) | \
> -			       read_nic_byte_E(dev, EPROM_CMD)); //enable EPROM
> -	else
> -		write_nic_byte_E(dev, EPROM_CMD, read_nic_byte_E(dev, EPROM_CMD)\
> -			       &~(1<<EPROM_CS_SHIFT)); //disable EPROM
> +				(1<<EPROM_CS_SHIFT) |
> +				read_nic_byte_E(dev, EPROM_CMD));
> +	} else {
> +		/* disable EPROM */
> +		write_nic_byte_E(dev, EPROM_CMD, read_nic_byte_E(dev, EPROM_CMD)
> +			       & ~(1<<EPROM_CS_SHIFT));
> +	}
>  
>  	force_pci_posting(dev);
>  	udelay(EPROM_DELAY);
> @@ -38,24 +41,24 @@ void eprom_cs(struct net_device *dev, short bit)
>  void eprom_ck_cycle(struct net_device *dev)
>  {
>  	write_nic_byte_E(dev, EPROM_CMD,
> -		       (1<<EPROM_CK_SHIFT) | read_nic_byte_E(dev,EPROM_CMD));
> +		       (1<<EPROM_CK_SHIFT) | read_nic_byte_E(dev, EPROM_CMD));
>  	force_pci_posting(dev);
>  	udelay(EPROM_DELAY);
>  	write_nic_byte_E(dev, EPROM_CMD,
> -		       read_nic_byte_E(dev, EPROM_CMD) &~ (1<<EPROM_CK_SHIFT));
> +		       read_nic_byte_E(dev, EPROM_CMD) & ~(1<<EPROM_CK_SHIFT));
>  	force_pci_posting(dev);
>  	udelay(EPROM_DELAY);
>  }
>  
>  
> -void eprom_w(struct net_device *dev,short bit)
> +void eprom_w(struct net_device *dev, short bit)
>  {
> -	if(bit)
> -		write_nic_byte_E(dev, EPROM_CMD, (1<<EPROM_W_SHIFT) | \
> -			       read_nic_byte_E(dev,EPROM_CMD));
> +	if (bit)
> +		write_nic_byte_E(dev, EPROM_CMD, (1<<EPROM_W_SHIFT) |
> +			       read_nic_byte_E(dev, EPROM_CMD));
>  	else
> -		write_nic_byte_E(dev, EPROM_CMD, read_nic_byte_E(dev,EPROM_CMD)\
> -			       &~(1<<EPROM_W_SHIFT));
> +		write_nic_byte_E(dev, EPROM_CMD, read_nic_byte_E(dev, EPROM_CMD)
> +			       & ~(1<<EPROM_W_SHIFT));
>  
>  	force_pci_posting(dev);
>  	udelay(EPROM_DELAY);
> @@ -66,11 +69,10 @@ short eprom_r(struct net_device *dev)
>  {
>  	short bit;
>  
> -	bit=(read_nic_byte_E(dev, EPROM_CMD) & (1<<EPROM_R_SHIFT) );
> +	bit = (read_nic_byte_E(dev, EPROM_CMD) & (1<<EPROM_R_SHIFT));
>  	udelay(EPROM_DELAY);
>  
> -	if(bit) return 1;
> -	return 0;
> +	return !!bit;

Oh come on, really?  !! is more "clear" here?

No, please be painfully obvious, that's the only way to write kernel
code.  Not like this.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/