linux-kernel - Re: [PATCH] staging: comedi: skel: use module_comedi_{pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120620231230.GA28411@kroah.com>
Date:	Wed, 20 Jun 2012 16:12:30 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, fmhess@...rs.sourceforge.net,
	abbotti@....co.uk
Subject: Re: [PATCH] staging: comedi: skel: use module_comedi_{pci_,}driver()

On Wed, Jun 20, 2012 at 03:56:50PM -0700, H Hartley Sweeten wrote:
> If PCI boards are supported, use the module_comedi_pci_driver() macro
> to register the module as a comedi driver and a PCI driver. Otherwise,
> only ISA boards are supported to use the module_comedi_driver() macro
> to register the module as a comedi driver.
> 
> Refactor the code a bit due to the use of the module_comedi_* macros.
> 
> Rename the comedi_driver and pci_driver variables as well as the pci
> driver related functions for aesthetic reasons. This makes the skel
> driver conform to the changes to the other comedi drivers.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Ian Abbott <abbotti@....co.uk>
> Cc: Frank Mori Hess <fmhess@...rs.sourceforge.net>

This patch fails to apply:

patching file drivers/staging/comedi/drivers/skel.c
Hunk #4 FAILED at 543.
1 out of 4 hunks FAILED -- saving rejects to file drivers/staging/comedi/drivers/skel.c.rej

Care to rediff it and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/