linux-kernel - Re: [PATCH] media: pms.c needs linux/slab.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Jun 2012 08:12:38 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Randy Dunlap <rdunlap@...otime.net>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-media <linux-media@...r.kernel.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] media: pms.c needs linux/slab.h

On 21/06/12 03:30, Randy Dunlap wrote:
> From: Randy Dunlap<rdunlap@...otime.net>
>
> drivers/media/video/pms.c uses kzalloc() and kfree() so it should
> include<linux/slab.h>  to fix build errors and a warning.
>
> drivers/media/video/pms.c:1047:2: error: implicit declaration of function 'kzalloc'
> drivers/media/video/pms.c:1047:6: warning: assignment makes pointer from integer without a cast
> drivers/media/video/pms.c:1116:2: error: implicit declaration of function 'kfree'
>
> Found in mmotm but applies to mainline.
>
> Signed-off-by: Randy Dunlap<rdunlap@...otime.net>
> Cc: Hans Verkuil<hverkuil@...all.nl>

Acked-by: Hans Verkuil <hans.verkuil@...co.com>

> ---
>   drivers/media/video/pms.c |    1 +
>   1 file changed, 1 insertion(+)
>
> --- mmotm-0619.orig/drivers/media/video/pms.c
> +++ mmotm-0619/drivers/media/video/pms.c
> @@ -29,6 +29,7 @@
>   #include<linux/ioport.h>
>   #include<linux/init.h>
>   #include<linux/mutex.h>
> +#include<linux/slab.h>
>   #include<linux/uaccess.h>
>   #include<linux/isa.h>
>   #include<asm/io.h>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/