linux-kernel - Re: [PATCH] staging: comedi: skel: use module_comedi_{pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FE2E2F5.1000300@mev.co.uk>
Date:	Thu, 21 Jun 2012 10:01:41 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
CC:	Greg KH <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	Ian Abbott <ian.abbott@....co.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: comedi: skel: use module_comedi_{pci_,}driver()

On 2012-06-21 01:21, H Hartley Sweeten wrote:
> Question.
>
> Is there a way to do a 'git commit' with the diff generated using the
> "patience diff" algorithm?
>
> I have a patch that is really ugly when I do the git commit but looks
> ok if I do a 'git diff --patience'.

You can generate patches with the different diff algorithms, but I don't 
think it makes any difference to what gets committed in the git 
repository, or rather it doesn't make any difference when patches are 
sent upstream from that intermediate repository as the diff will be 
regenerated on the fly.

I guess your ugly patch is moving stuff around to avoid forward 
declarations?  Splitting it up into a number of steps seems to help in 
that case.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/