linux-kernel - Re: [PATCH 2/3] regulator: replace devm_gpio_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120621092026.GJ4037@opensource.wolfsonmicro.com>
Date:	Thu, 21 Jun 2012 10:20:27 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"Girdwood, Liam" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"axel.lin@...il.com" <axel.lin@...il.com>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>
Subject: Re: [PATCH 2/3] regulator: replace devm_gpio_request_one() for
 loaded module

On Thu, Jun 21, 2012 at 08:03:48AM +0000, Kim, Milo wrote:
> At this moment, devm_gpio_request_one() has not been exported yet.
> But lp872x driver can be used as a module, so related functions should be changed.
> 
> devm_gpio_request_one() -> gpio_request_one() and gpio_free()

No, this is a step back in terms of the quality of the driver especially
given that nobody is likely to actually use the driver when built as a
module.  We should just wait until the function is exported and then
reenable modular builds.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)