linux-kernel - Re: SNB PCI root information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOPLpQdLSfHn4=zHVYpZMcw1cHPwtV3He-Sxng_yjGKwdpBK8A@mail.gmail.com>
Date:	Thu, 21 Jun 2012 12:22:17 -0400
From:	Ulrich Drepper <drepper@...il.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>, jbarnes@...tuousgeek.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	lenb@...nel.org, x86@...nel.org, linux-pci@...r.kernel.org
Subject: Re: SNB PCI root information

On Thu, Jun 21, 2012 at 8:17 AM, Ulrich Drepper <drepper@...il.com> wrote:
> On Wed, Jun 20, 2012 at 11:50 PM, Yinghai Lu <yinghai@...nel.org> wrote:
>> please check -v3, and it will add 40 lines.
>
> Won't this version print out something like
>
>  PCI: unknown option `busnum_node=xx:yy'

It does.

If you apply the following patch on top of your version 3 patch it
seems to work and is slightly more efficient.


Signed-off-by: Ulrich Drepper <drepper@...il.com>

diff -u b/arch/x86/pci/common.c b/arch/x86/pci/common.c
--- b/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -494,16 +494,22 @@
 	return 0;
 }

+static const char *busnum_node_param;
+
+static void remember_busnum_node(const char *str)
+{
+	busnum_node_param = str;
+}
+
 int get_user_busnum_node(int busnum)
 {
 	int bus, node, count;
-	char *p;
+	const char *p;

-	p = strstr(boot_command_line, "busnum_node=");
+	p = busnum_node_param;
 	if (!p)
 		return -1;

-	p += 12; /* strlen("busnum_node=") */
 	while (*p) {
 		count = 0;
 		if (sscanf(p, "%x:%x%n", &bus, &node, &count) != 2) {
@@ -607,6 +613,9 @@
 	} else if (!strcmp(str, "nocrs")) {
 		pci_probe |= PCI_ROOT_NO_CRS;
 		return NULL;
+	} else if (!strncmp(str, "busnum_node=", 12)) {
+		remember_busnum_node(str + 12);
+		return NULL;
 	} else if (!strcmp(str, "earlydump")) {
 		pci_early_dump_regs = 1;
 		return NULL;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/