linux-kernel - Re: [PATCH -mm 2/7] mm: get unmapped area from VMA tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FE350D1.4070503@redhat.com>
Date:	Thu, 21 Jun 2012 12:50:25 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Johannes Weiner <hannes@...xchg.org>
CC:	linux-mm@...ck.org, akpm@...ux-foundation.org, aarcange@...hat.com,
	peterz@...radead.org, minchan@...il.com, kosaki.motohiro@...il.com,
	andi@...stfloor.org, mel@....ul.ie, linux-kernel@...r.kernel.org,
	Rik van Riel <riel@...riel.com>
Subject: Re: [PATCH -mm 2/7] mm: get unmapped area from VMA tree

On 06/21/2012 05:01 AM, Johannes Weiner wrote:

>> +		/* Go left if it looks promising. */
>> +		if (node_free_hole(rb_node->rb_left)>= len&&
>> +					vma->vm_start - len>= lower_limit) {
>> +			rb_node = rb_node->rb_left;
>> +			continue;
>
> If we already are at a vma whose start has a lower address than the
> overall length, does it make sense to check for a left hole?
> I.e. shouldn't this be inside the if (vma->vm_start>  len) block?

You are right, I can move this in under the
conditional.

>> +		if (!found_here&&  node_free_hole(rb_node->rb_left)>= len) {
>> +			/* Last known hole is to the right of this subtree. */
>
> "to the left"

Actually, it is to the right.  We walked left from
our parent to get here, so the holes found so far
are to the right of here.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/