linux-kernel - [PATCH 1/9] PCI: Remove redundant debug output in pci_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120621202423.16865.50394.stgit@amt.stowe>
Date:	Thu, 21 Jun 2012 14:24:23 -0600
From:	Myron Stowe <myron.stowe@...hat.com>
To:	bhelgaas@...gle.com
Cc:	linux-pci@...r.kernel.org, linux@....linux.org.uk,
	ralf@...ux-mips.org, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org
Subject: [PATCH 1/9] PCI: Remove redundant debug output in pci_do_fixups

When the boot argument 'initcall_debug' is specified, redundant debug
output occurs for each device as a quirk is applied:
  ...
  pci 0000:00:1a.0: calling quirk_usb_early_handoff+0x0/0x620
  calling  quirk_usb_early_handoff+0x0/0x620 @ 1 for 0000:00:1a.0
  pci fixup quirk_usb_early_handoff+0x0/0x620 returned after 32 usecs for 0000:00: 1a.0
  ...

This patch removes the redundancy by eliminating the first debug output
occurence in the sequence shown above when 'initcall_debug' is specified.

Signed-off-by: Myron Stowe <myron.stowe@...hat.com>
---

 drivers/pci/quirks.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index a2d9d33..9c93558 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2953,11 +2953,12 @@ static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f,
 		     f->vendor == (u16) PCI_ANY_ID) &&
 		    (f->device == dev->device ||
 		     f->device == (u16) PCI_ANY_ID)) {
-			dev_dbg(&dev->dev, "calling %pF\n", f->hook);
 			if (initcall_debug)
 				do_one_fixup_debug(f->hook, dev);
-			else
+			else {
+				dev_dbg(&dev->dev, "calling %pF\n", f->hook);
 				f->hook(dev);
+			}
 		}
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/