linux-kernel - Re: [PATCH 1/2] x86, apic: optimize cpu traversal in __assign_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340315598.3696.89.camel@sbsiddha-desk.sc.intel.com>
Date:	Thu, 21 Jun 2012 14:53:18 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Alexander Gordeev <agordeev@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>, yinghai@...nel.org,
	linux-kernel@...r.kernel.org, x86@...nel.org, gorcunov@...nvz.org
Subject: Re: [PATCH 1/2] x86, apic: optimize cpu traversal in
 __assign_irq_vector() using domain membership

On Thu, 2012-06-21 at 10:31 +0200, Alexander Gordeev wrote:
> On Tue, Jun 19, 2012 at 04:43:30PM -0700, Suresh Siddha wrote:
> > Use the irq_cfg's old_domain to track the visited domains and optimize
> > the cpu traversal while finding a free vector in the given cpumask.
> > 
> > NOTE: We can also optimize the search by using for_each_cpu and skip the
> > current cpu, if it is not the first cpu in the mask returned by the
> > vector_allocation_domain(). But re-using the cfg->old_domain to track
> > the visited domains will be slightly faster.
> 
> Sorry for the dealy, Suresh.
> 
> You also need to kick out vector_allocation_domain's return value in all other
> apic drivers.

this patch is on top of -tip which already has your patch which
consolidates different vector_allocation_domains to relatively few. I
double checked and don't seem to left out any other apic driver.

thanks,
suresh


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/