linux-kernel - Re: [PATCH v3] sched: balance_cpu to consider other cpus in its group as target of (pinned) task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FE2B013.7090108@linux.vnet.ibm.com>
Date:	Thu, 21 Jun 2012 10:54:35 +0530
From:	Prashanth Nageshappa <prashanth@...ux.vnet.ibm.com>
To:	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
CC:	Peter Zijlstra <peterz@...radead.org>, mingo@...nel.org,
	LKML <linux-kernel@...r.kernel.org>, roland@...nel.org,
	efault@....de, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH v3] sched: balance_cpu to consider other cpus in its group
 as target of (pinned) task

On 06/21/2012 09:53 AM, Srivatsa Vaddagiri wrote:

> * Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com> [2012-06-21 09:10:59]:
> 
>> Hmm ..I can see loop_break being incremented here:
>>
>>                 /* take a breather every nr_migrate tasks */
>>                 if (env->loop > env->loop_break) {
>>                         env->loop_break += sched_nr_migrate_break;
> 
> One possibility is to reset env->loop here, rather than loop_break, in
> which case loop_break can remain constant across "redos" and
> "more_balances"

We cannot do this as env->loop is compared with env->loop_max. So, I
believe resetting env->loop_break along with env->loop before "redos"
and "more_balances" is the right thing to do.

- Prashanth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/