linux-kernel - Re: [PATCH] x86, cpufeature: Fix duplicate feature name "dts"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4FE434C0020000780008B45A@nat28.tlf.novell.com>
Date:	Fri, 22 Jun 2012 08:02:56 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Jean Delvare" <khali@...ux-fr.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>, <x86@...nel.org>,
	"LKML" <linux-kernel@...r.kernel.org>, <hpa@...or.com>
Subject: Re: [PATCH] x86, cpufeature: Fix duplicate feature name "dts"

>>> On 21.06.12 at 18:28, "H. Peter Anvin" <hpa@...ux.intel.com> wrote:
> Good spotting, but I'm worried this is the wrong fix.
> 
> This is a userspace ABI change, and the and we have used "dts" for debug
> store (debug trace store?) for a very long tie, whereas digital thermal
> sensor only has been used since 2010; another *major* question is which
> of these is more likely to be of interest to userspace.
> 
> Jan, do you have any feeling on this?

Now that you already figured that there is user space code
depending on the current (questionable) string, I don't think
it matters much - I would have preferred to correct the string
to match the CPUID documentation (albeit I seem to recall
that early on the bit was indeed named DTS in the doc).

Wouldn't it be helpful if mkcapflags.pl detected duplicates?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/