linux-kernel - Re: [PATCH V3 2/3] regulator: dt: regulator match by regulator-compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120622085909.GA24121@avionic-0098.mockup.avionic-design.de>
Date:	Fri, 22 Jun 2012 10:59:09 +0200
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Arnd Bergmann <arnd@...db.de>, devicetree-discuss@...ts.ozlabs.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	rob.herring@...xeda.com, Laxman Dewangan <ldewangan@...dia.com>,
	lee.jones@...aro.org, lrg@...com,
	Stephen Warren <swarren@...dotorg.org>
Subject: Re: [PATCH V3 2/3] regulator: dt: regulator match by
 regulator-compatible

On Fri, Jun 22, 2012 at 09:42:29AM +0100, Mark Brown wrote:
> On Fri, Jun 22, 2012 at 08:13:14AM +0200, Thierry Reding wrote:
> > On Wed, Jun 20, 2012 at 08:46:10PM +0100, Mark Brown wrote:
> 
> > > As well as being able to refer to the object from within the device tree
> > > we also need to be able to tell what the object represents - we have a
> > > bunch of regulators in an array under a node for a PMIC and we want to
> > > know which regulator on the physical device each array entry corresponds
> > > to.  Previously this was being done by parsing the phandle name but that
> > > means we can't have more than one device with the same set of names.
> 
> > I thought the reason was that matching the node names up with the
> > regulator names was considered bad practice. As Stephen already noticed,
> > the matching is done by node name, not phandle. Correct me if I'm wrong,
> > but you can have more than one device with the children have the same
> > names.
> 
> We're talking about consumers here, not the regulator driver finding its
> own regulators.

No we're not. of_regulator_match() isn't used by consumers but by
regulator drivers to parse the DT.

Thierry

Content of type "application/pgp-signature" skipped