linux-kernel - Re: [PATCH][RT] spinlock: Add include for BUG() in spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1206221108180.2853@ionos>
Date:	Fri, 22 Jun 2012 11:08:51 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Steven Rostedt <rostedt@...dmis.org>
cc:	LKML <linux-kernel@...r.kernel.org>,
	RT <linux-rt-users@...r.kernel.org>,
	leroy christophe <christophe.leroy@....fr>,
	Iratxo Pichel Ortiz <ipichel@...entia.com>,
	David Garcia <dgarcia@...entia.com>
Subject: Re: [PATCH][RT] spinlock: Add include for BUG() in spinlock_rt.h

On Thu, 21 Jun 2012, Steven Rostedt wrote:

> spinlock_rt.h references BUG(), but it does not include bug.h, and on
> some architectures (powerpc) this can cause a build failure.
> 
> Reported-by: Iratxo Pichel Ortiz <ipichel@...entia.com>
> Reported-by: leroy christophe <christophe.leroy@....fr>
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> ----
> [ Thomas, can you add this patch to your queue so that I can add it to
> stable. Please, let me know when you have. Thanks! ]

Picked it up, thanks. Please take it right away w/o waiting for my
release.

Thanks,

	Thomas

 
> diff --git a/include/linux/spinlock_rt.h b/include/linux/spinlock_rt.h
> index 3b555b4..0618387 100644
> --- a/include/linux/spinlock_rt.h
> +++ b/include/linux/spinlock_rt.h
> @@ -5,6 +5,8 @@
>  #error Do not include directly. Use spinlock.h
>  #endif
>  
> +#include <linux/bug.h>
> +
>  extern void
>  __rt_spin_lock_init(spinlock_t *lock, char *name, struct lock_class_key *key);
>  
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/