linux-kernel - Re: [PATCH] usb: host: xhci: Compliance Mode port recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120622014058.GA3220@kroah.com>
Date:	Thu, 21 Jun 2012 18:40:58 -0700
From:	'Greg KH' <gregkh@...uxfoundation.org>
To:	Alexis Cortes <alexis.cortes@...com>
Cc:	'Sarah Sharp' <sarah.a.sharp@...ux.intel.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	"'Quach, Brian'" <brian.quach@...com>,
	"'Llamas, Jorge'" <jorge.llamas@...com>
Subject: Re: [PATCH] usb: host: xhci: Compliance Mode port recovery

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Jun 21, 2012 at 12:31:12PM -0500, Alexis Cortes wrote:
> As Sarah proposed, we certainly can apply this patch as a module parameter
> disabled by default and let know our clients that we know are using this
> re-driver to enable the feature to avoid the issue.

Who is a "client"?  And who is going to modify the installer of their
distro in order to automatically enable this option?

That's the problem with options, you never know if you need to turn it
on or not, so I _really_ don't ever want to add any more, the kernel
should "just know" if it needs to be enabled or not.  Surely there is
some way for the kernel to determine if this is your code/hardware
running on the platform or not, right?  No signature in the system
anywhere?  PCI id? DMI table?  ACPI table?  BIOS signature?  Something
else?

You really don't want to be responsible for dealing with 10+ distros in
telling them when they should, or should not, enable this option.  So
please don't create it in the first place.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/