linux-kernel - RE: [PATCH] Staging: comedi: fixed print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Jun 2012 11:16:42 -0500
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Daniel Lawrence <daniel@...ielscottlawrence.com>,
	"abbotti@....co.uk" <abbotti@....co.uk>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Staging: comedi: fixed print_k coding style issue in
 acl7225b.c

On Friday, June 22, 2012 6:00 AM, Danny Lawrence wrote:
> This is a patch to the acl7225b.c file that fixes up 2 print_k warnings
> found by the checkpatch.pl tool.
>
> Signed-off-by: Daniel Lawrence <daniel@...ielscottlawrence.com>
> ---
>  drivers/staging/comedi/drivers/acl7225b.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
> index 4e4fc41..5392358 100644
> --- a/drivers/staging/comedi/drivers/acl7225b.c
> +++ b/drivers/staging/comedi/drivers/acl7225b.c
> @@ -72,10 +72,10 @@ static int acl7225b_attach(struct comedi_device *dev,
>  
>  	iobase = it->options[0];
>  	iorange = this_board->io_range;
> -	printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
> +	pr_info("comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
>  	       this_board->name, iobase);
>  	if (!request_region(iobase, iorange, "acl7225b")) {
> -		printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n",
> +		pr_err("comedi%d: request_region failed - I/O port conflict\n",
>  			dev->minor);
>  		return -EIO;
>  	}

Fixes to this type of issue in the comedi drivers should change the printk's
to the dev_printk style.

Hint, the format:

dev_info(dev->class_dev, "whatever\n");

Will automatically provide the "comedi%d: " part of the output.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/