linux-kernel - Re: [PATCH] usb: host: xhci: Compliance Mode port recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Jun 2012 09:44:23 -0700
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	'Greg KH' <gregkh@...uxfoundation.org>
Cc:	Alexis Cortes <alexis.cortes@...com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"'Quach, Brian'" <brian.quach@...com>,
	"'Llamas, Jorge'" <jorge.llamas@...com>
Subject: Re: [PATCH] usb: host: xhci: Compliance Mode port recovery

On Thu, Jun 21, 2012 at 06:48:25PM -0700, 'Greg KH' wrote:
> On Thu, Jun 21, 2012 at 05:08:58PM -0700, Sarah Sharp wrote:
> > Greg, what about exporting a sysfs file to change the polling interval?
> > We could run the timer every 2 seconds by default, but get powertop to
> > add a new setting for turning the interval off.
> 
> Ick, a sysfs file is almost as bad as a kernel module option, how are
> you going to tell users / distros when to turn it off or not if you
> don't know if it is needed or not?

The same way users discover whether their USB devices break if
auto-suspend is turned on.  They go into powertop, and change the line
for their USB device from "BAD" to "GOOD".  Then they notice their mouse
suddenly stops responding to movement, and they change the powertop
settings back.

In the same way, there would be a line like "Stop xHCI port polling
timer" that they would toggle.  Later, if devices under the ports
stopped enumerating, they would change it back to "BAD" and just put up
with the polling.

I agree it's not a very good system, and adding a quirk to the xHCI
driver is a better solution.  Ideally, TI would just fix their redriver.

> We really need a way to determine the hardware here.
> 
> Alexis, what are you doing on Windows for this?  Surely you can't be
> turning a timer on every 2 seconds for all Windows systems in the world,
> are you?

Yes, what are you going to do for Windows 8 systems that have official
Microsoft USB 3.0 support?  Make your customers ship a driver with the
polling turned on?

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/