linux-kernel - Re: [PATCH] x86, cpufeature: Fix duplicate feature name "dts"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FE4B2F7.9070302@zytor.com>
Date:	Fri, 22 Jun 2012 11:01:27 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Borislav Petkov <borislav.petkov@....com>,
	Jean Delvare <khali@...ux-fr.org>, x86@...nel.org,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Jan Beulich <JBeulich@...e.com>,
	Guenter Roeck <guenter.roeck@...csson.com>
Subject: Re: [PATCH] x86, cpufeature: Fix duplicate feature name "dts"

On 06/21/2012 11:59 PM, Ingo Molnar wrote:
> 
> Plus add a kernel build time check to avoid such string clashes 
> in the future? These acronyms tend to be short and hard to read, 
> I'd not be surprised if this repeated in the future.
> 

Another *MASSIVE* fail is that an x86 cpufeature was added by a patch
that went through the hwmon tree without any x86 maintainer ACK, and
with a subject line that would not have made anyone aware of it:

a4659053 x86/hwmon: fix initialization of coretemp

We maintain x86/cpufeature as a separate -tip branch for a reason:
changes to that stuff mucks with *everything* as it is.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/