linux-kernel - Re: [PATCH] Taint kernel when lve module is loaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120622194014.GA12874@kroah.com>
Date:	Fri, 22 Jun 2012 12:40:14 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	richard -rw- weinberger <richard.weinberger@...il.com>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>,
	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au,
	Alex Lyashkov <umka@...udlinux.com>
Subject: Re: [PATCH] Taint kernel when lve module is loaded

On Fri, Jun 22, 2012 at 09:09:22PM +0200, richard -rw- weinberger wrote:
> On Fri, Jun 22, 2012 at 7:49 PM, Matthew Garrett <mjg59@...f.ucam.org> wrote:
> > Cloudlinux have a product called lve that includes a kernel module. This
> > was previously GPLed but is now under a proprietary license, but the
> > module continues to declare MODULE_LICENSE("GPL") and makes use of some
> > EXPORT_SYMBOL_GPL symbols. Forcibly taint it in order to avoid this.
> >
> > Signed-off-by: Matthew Garrett <mjg59@...f.ucam.org>
> > Cc: Alex Lyashkov <umka@...udlinux.com>
> > ---
> >  kernel/module.c |    4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/kernel/module.c b/kernel/module.c
> > index 4edbd9c..9ad9ee9 100644
> > --- a/kernel/module.c
> > +++ b/kernel/module.c
> > @@ -2730,6 +2730,10 @@ static int check_module_license_and_versions(struct module *mod)
> >        if (strcmp(mod->name, "driverloader") == 0)
> >                add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
> >
> > +       /* lve claims to be GPL but upstream won't provide source */
> > +       if (strcmp(mod->name, "lve") == 0)
> > +               add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
> > +
> 
> If this kernel module is really lying to us the kernel should simply
> refuse to load it and
> call a lawyer.

The kernel can't call a lawyer, but other than that, this change does
prevent the module from being loaded.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/