linux-kernel - Re: [PATCH] reboot: disable nonboot CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120622135704.658eb79c.akpm@linux-foundation.org>
Date:	Fri, 22 Jun 2012 13:57:04 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
Cc:	Kees Cook <keescook@...omium.org>,
	Per Forlin <per.forlin@...ricsson.com>,
	linux-kernel@...r.kernel.org, serge.hallyn@...onical.com,
	Linus Walleij <linus.walleij@...aro.org>,
	Per Forlin <per.lkml@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] reboot: disable nonboot CPUs

On Fri, 15 Jun 2012 01:48:34 +0400
Cyrill Gorcunov <gorcunov@...nvz.org> wrote:

> On Thu, Jun 14, 2012 at 02:41:48PM -0700, Kees Cook wrote:
> > On Thu, Jun 14, 2012 at 2:25 PM, Per Forlin <per.forlin@...ricsson.com> wrote:
> > > Disable the nonboot CPUs to safely migrate tasks and interrupts
> > > to the boot CPU. This will prevent the nonboot CPUs to
> > > interfer or block the boot CPU from being able to reboot
> > > the system successfully.
> > 
> > Reviewed-by: Kees Cook <keescook@...omium.org>
> > 
> > This seems reasonable to me, though I haven't looked too deeply at the
> > reboot path.
> 
> Looks reasonable to me as well, but better to add some more CC,

That worked well :(

> since syscore_shutdown seems to call for generic irqs to shutdown
> when cpu get turned off already, not sure if this have any side
> effect and/or I've missed something (Thomas CC'ed).

Let's use the scientific method: stick it in the tree and see what
happens.  If it breaks, we fix or revert it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/