linux-kernel - Re: [PATCH 1/1 v4] leds: Add LED driver for lm3556 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK5ve-K=Cr4jg0aN128DN4nQLBHzJ4kocBs3D53PU0PWsUy_1A@mail.gmail.com>
Date:	Fri, 22 Jun 2012 11:10:55 +0800
From:	Bryan Wu <bryan.wu@...onical.com>
To:	"G.Shark Jeong" <gshark.jeong@...il.com>,
	"Kim, Milo" <Milo.Kim@...com>, Axel Lin <axel.lin@...il.com>
Cc:	"Jeong, Daniel" <Daniel.Jeong@...com>,
	Rob Landley <rob@...dley.net>,
	Richard Purdie <rpurdie@...ys.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH 1/1 v4] leds: Add LED driver for lm3556 chip

On Fri, Jun 22, 2012 at 9:05 AM, Kim, Milo <Milo.Kim@...com> wrote:
>> LM3556 :
>> The LM3556 is a 4 MHz fixed-frequency synchronous boost
>> converter plus 1.5A constant current driver for a high-current white
>> LED.
>
> Overall, it looks pretty good to me, especially core functionality of lm3556 is well supported and it's easy to use.
>
> Just one thing to be better,
> I would suggest to use module_i2c_driver() rather than lm3556_init/lm3556_exit for code simplicity.
>

Hi G.Shark,

I also think this patch is good enough for merging now after your
fixed several issues pointed out by Axel Lin.
I fixed this module_i2c_driver() issue mentioned by Milo here and push
it to my -devel branch.
If there is no problem, I will applied it to for-next branch.

Thanks,
-Bryan

>> +static int __init lm3556_init(void)
>> +{
>> +     return i2c_add_driver(&lm3556_i2c_driver);
>> +}
>> +
>> +static void __exit lm3556_exit(void)
>> +{
>> +     i2c_del_driver(&lm3556_i2c_driver);
>> +}
>> +
>> +module_init(lm3556_init);
>> +module_exit(lm3556_exit);
>
> module_i2c_driver(lm3556_i2c_driver);
>
> Thanks,
> Milo -



-- 
Bryan Wu <bryan.wu@...onical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/