linux-kernel - Re: [PATCH 2/2] staging: zram: Remove useless struct zobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 23 Jun 2012 18:18:19 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Marcos Paulo de Souza <marcos.souza.org@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-mm-cc@...top.org, linux-kernel@...r.kernel.org,
	ngupta@...are.org
Subject: Re: [PATCH 2/2] staging: zram: Remove useless struct zobj_header

On Thu, Jun 21, 2012 at 12:32:45AM -0300, Marcos Paulo de Souza wrote:
> The struct zobj_header has no members, so the sizeof(struct zobj_header *)
> always returns zero. For this reason we are removing this useless struct.
> 

I've been out for the past few days and I'm slowly catching up.  If
you want you could update this comment as well:

drivers/staging/zram/zram_drv.h
    40  /*
    41   * NOTE: max_zpage_size must be less than or equal to:
    42   *   ZS_MAX_ALLOC_SIZE - sizeof(struct zobj_header)
    43   * otherwise, xv_malloc() would always return failure.
    44   */

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/