linux-kernel - cris: odd include in arch/cris/boot/compressed/misc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340413223.1773.146.camel@x61.thuisdomein>
Date:	Sat, 23 Jun 2012 03:00:23 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Mikael Starvik <starvik@...s.com>,
	Jesper Nilsson <jesper.nilsson@...s.com>
Cc:	linux-cris-kernel@...s.com, linux-kernel@...r.kernel.org
Subject: cris: odd include in arch/cris/boot/compressed/misc.c

Mikael, Jesper,

0) Currently line 123 of arch/cris/boot/compressed/misc.c reads:
    #include "../../../../../lib/inflate.c"

git blame tells me that line has read that way since commit
51533b615e605d86154ec1b4e585c8ca1b0b15b7 ("[...] CRIS update: new
subarchitecture v32"), which predates release v2.6.13.

1) When I try to jump to lib/inflate.c via that line in my $EDITOR, I
see an error and nothing happens. When I check the depth, in
directories, at which misc.c lives, I can't blame my $EDITOR.

2) And indeed, when I edit that line to read:
    #include "../../../../lib/inflate.c"

my $EDITOR does correctly jump to lib/inflate.c. 

3) This can be trivially fixed, and I'm happy to submit that trivial
patch. But I do wonder what the compilers for cris know that my $EDITOR
and x86 compiler doesn't. (I don't have a compiler for cris at hand.)
Because, if I edit the comparable file for x86 to have a similar include
look that way and try to build a kernel I get:

[...]
  CC      arch/x86/boot/compressed/misc.o
arch/x86/boot/compressed/misc.c:131:51: fatal error: ../../../../../lib/decompress_inflate.c: No such file or directory
compilation terminated.
make[2]: *** [arch/x86/boot/compressed/misc.o] Error 1
make[1]: *** [arch/x86/boot/compressed/vmlinux] Error 2
make: *** [bzImage] Error 2

4) What's going on here?

Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/