linux-kernel - Re: [patch 046/181] mm: remove sparsemem allocation details from the bootmem allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQXYG0=XFAzZStExBTNqdnRPMSjASNydM45GC_G6qfuNkA@mail.gmail.com>
Date:	Sat, 23 Jun 2012 11:58:02 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	davem@...emloft.net, shangw@...ux.vnet.ibm.com, tj@...nel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [patch 046/181] mm: remove sparsemem allocation details from the
 bootmem allocator

On Sat, Jun 23, 2012 at 2:17 AM, Johannes Weiner <hannes@...xchg.org> wrote:
> On Fri, Jun 22, 2012 at 07:05:45PM -0700, Yinghai Lu wrote:
>> On Fri, Jun 22, 2012 at 6:11 PM, Yinghai Lu <yinghai@...nel.org> wrote:
>> > On Tue, May 29, 2012 at 3:06 PM,  <akpm@...ux-foundation.org> wrote:
>> >> From: Johannes Weiner <hannes@...xchg.org>
>> >> Subject: mm: remove sparsemem allocation details from the bootmem allocator
>> >>
>> >> alloc_bootmem_section() derives allocation area constraints from the
>> >> specified sparsemem section.  This is a bit specific for a generic memory
>> >> allocator like bootmem, though, so move it over to sparsemem.
>> >>
>> >> As __alloc_bootmem_node_nopanic() already retries failed allocations with
>> >> relaxed area constraints, the fallback code in sparsemem.c can be removed
>> >> and the code becomes a bit more compact overall.
>> >>
>> >> [akpm@...ux-foundation.org: fix build]
>> >> Signed-off-by: Johannes Weiner <hannes@...xchg.org>
>> >> Acked-by: Tejun Heo <tj@...nel.org>
>> >> Acked-by: David S. Miller <davem@...emloft.net>
>> >> Cc: Yinghai Lu <yinghai@...nel.org>
>> >> Cc: Gavin Shan <shangw@...ux.vnet.ibm.com>
>> >> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>> >
>> > hi, this one cause regression, will put usemap to last node's memory
>> > instead of each node.
>>
>> attached patch fixes the problem.
>
> Sorry for the trouble and thanks for the patch!  The number of bugs in
> these three lines is too damn high...
>
yeah, i should run Andrew -mm early.

Andrew, Do you have git tree for your -mm?
So I could merge it to my local tree.
now i only have tip, pci, scsi, net, driver-core, usb, tty in my local tree.

...
>>        */
>> -     goal = __pa(pgdat) & PAGE_SECTION_MASK;
>> +     goal = ((__pa(pgdat) >> PAGE_SHIFT) & PAGE_SECTION_MASK) << PAGE_SHIFT;
>
> How about
>
>        goal = __pa(pgdat) & (PAGE_SECTION_MASK << PAGE_SHIFT);
>
> instead?

yeah.

After closely looking, looks like we need to revert the commit or
apply -v2 patch.

old sequence is : try same section range at first.
this commit will try [start_of_section, end_of_same_node_range], so
could have chance to get

Yinghai

Download attachment "fix_usemap_goal_v2.patch" of type "application/octet-stream" (3460 bytes)