linux-kernel - Re: [PATCH V2 1/3] staging/rtl8192u: fix coding style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1340484715.7758.22.camel@joe2Laptop>
Date:	Sat, 23 Jun 2012 13:51:55 -0700
From:	Joe Perches <joe@...ches.com>
To:	"devendra.aaru" <devendra.aaru@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Justin P. Mattock" <justinmattock@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/3] staging/rtl8192u: fix coding style problems

On Sun, 2012-06-24 at 00:04 +0530, devendra.aaru wrote:
> Hi Joe,

Hi Devendra.

> On Thu, Jun 21, 2012 at 4:48 AM, Joe Perches <joe@...ches.com> wrote:
> > I'd just make the return a bool instead.

>  taking another variable and assign it like bool ret = !!bit, and
> returning ret?, i think this doesn't look better.

No. just
	return val;
or
	return (bool)val;

if using the implicit conversion bothers you.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/