linux-kernel - Re: [PATCH 1/5] thinkpad_acpi: Drop pm_message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120624003224.GA20885@khazad-dum.debian.net>
Date:	Sat, 23 Jun 2012 21:32:24 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	platform-driver-x86@...r.kernel.org,
	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Joey Lee <jlee@...ell.com>
Subject: Re: [PATCH 1/5] thinkpad_acpi: Drop pm_message_t arguments from
 suspend routines

On Sun, 17 Jun 2012, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> Multiple suspend routines in drivers/platform/x86/thinkpad_acpi.c
> use take pm_message_t arguments that aren't used by any of them.
> Make those routines take no arguments as that's what they should do.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>

Someday it might be necessary for some of these routines to differentiate S3
from suspend-to-disk, but I will introduce a parameter when that day comes.

Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/