linux-kernel - Re: [PATCH] staging: vt6656: Style cleanup of iwctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120624204711.GK5390@mwanda>
Date:	Sun, 24 Jun 2012 23:47:11 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Forest Bond <forest@...ttletooquiet.net>,
	Marcos Paulo de Souza <marcos.mage@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Style cleanup of iwctl

On Sun, Jun 24, 2012 at 09:45:58PM +0200, Jesper Juhl wrote:
> Clean up the files iwctl.c and iwctl.h to match the official
> CodingStyle a bit more closely.
> 
> This is *not* a complete cleanup, but it brings the files quite close
> to the accepted style compared to the state they were originally in
> (which was a complete mess IMHO).
> 
> It's mostly just whitespace changes, but there are also a few
> pointless casts that were removed, a few tiny reshuffelings of code to
> reduce indentation etc, but nothing major. There are no functional
> changes.
> 
> I could have split this in multiple patches, I guess, but then I'd
> probably have ended up with a bunch of patches all touching the same
> lines multiple times in order to make multiple different changes and
> that didn't seem worth it.  I opted to just do the whole thing in one
> big patch, then we at least have a sane base upon which to apply
> future smaller cleanups.

Nope.  It is worth it.  Broken out patches are a million times
easier to review.

It frustrates me that you would do things like this when you know
the rules.  Which part is difficult to understand?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/