linux-kernel - Re: vfs/for-next: NULL pointer dereference in sysfs_dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120624092034.GP14083@ZenIV.linux.org.uk>
Date:	Sun, 24 Jun 2012 10:20:34 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	wfg@...ux.intel.com
Cc:	linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: vfs/for-next: NULL pointer dereference in sysfs_dentry_delete()

On Sun, Jun 24, 2012 at 04:07:40PM +0800, wfg@...ux.intel.com wrote:
> Hi Al,
> 
> This commit
> 
>         commit 08eaca322cb2720f1730e46793dee9464ebd26f2
>         Author: Al Viro <viro@...iv.linux.org.uk>
>         Date:   Thu Jun 7 20:51:39 2012 -0400
> 
>             sysfs: switch to ->s_d_op and ->d_release()
>             
> triggers the following bug:

Arrgh....
It needs
static int sysfs_dentry_delete(const struct dentry *dentry)
{
        struct sysfs_dirent *sd = dentry->d_fsdata;
        return !(sd && !(sd->s_flags & SYSFS_FLAG_REMOVED));
}

Will fold and push in a few

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/