linux-kernel - Re: [PATCH] Extcon: Arizona: Add driver for Wolfson Arizona class devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120625085151.GB4037@opensource.wolfsonmicro.com>
Date:	Mon, 25 Jun 2012 09:51:52 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	함명주 <myungjoo.ham@...sung.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	박경민 <kyungmin.park@...sung.com>,
	"patches@...nsource.wolfsonmicro.com" 
	<patches@...nsource.wolfsonmicro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Extcon: Arizona: Add driver for Wolfson Arizona class
 devices

On Mon, Jun 25, 2012 at 04:48:21AM +0000, 함명주 wrote:

> > +	/* Microphone detection can't use idle mode */
> > +	pm_runtime_get(info->dev);

> Is it alright to use asynchronous get here?
> (sync not required?)

Yes, it's OK to do this - we're guaranteed that the device is already
enabled at the time we decide to start the microphone detection (as
we're in the middle of examining the state which needs a runtime
reference).  We're taking an additional reference here so that the
device doesn't get powered off again after the event has been handled.

> > +	ret = arizona_request_irq(arizona, ARIZONA_IRQ_JD_RISE,
> > +				  "JACKDET rise", arizona_jackdet, info);

> Is this arizone_request_irq using threaded irq? (it's fine if so)

Yes.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)