linux-kernel - Re: [PATCH] HID: magicmouse: Correct report range of major / minor axes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120625120407.GA522@polaris.bitmath.org>
Date:	Mon, 25 Jun 2012 14:04:07 +0200
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Yufeng Shen <miletus@...omium.org>
Cc:	linux-input@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>,
	linux-kernel@...r.kernel.org,
	Andrew de los Reyes <adlr@...omium.org>
Subject: Re: [PATCH] HID: magicmouse: Correct report range of major / minor
 axes

On Fri, Jun 22, 2012 at 12:31:53PM -0400, Yufeng Shen wrote:
> In patch "HID: magicmouse: Adjust major / minor axes to scale",
> touch_major and touch_minor axes are scaled by a factor of
> four when reported but the max touch_major/minor is not scaled
> accordingly. This patch scales the max touch_major/minor to
> be consistent with the reported value.
> 
> Signed-off-by: Yufeng Shen <miletus@...omium.org>
> ---
>  drivers/hid/hid-magicmouse.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
> index 7cf3ffe..40ac665 100644
> --- a/drivers/hid/hid-magicmouse.c
> +++ b/drivers/hid/hid-magicmouse.c
> @@ -426,8 +426,10 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h
>  		__set_bit(EV_ABS, input->evbit);
>  
>  		input_set_abs_params(input, ABS_MT_TRACKING_ID, 0, 15, 0, 0);
> -		input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, 255, 4, 0);
> -		input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, 255, 4, 0);
> +		input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, 255 << 2,
> +				     4, 0);
> +		input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, 255 << 2,
> +				     4, 0);
>  		input_set_abs_params(input, ABS_MT_ORIENTATION, -31, 32, 1, 0);
>  
>  		/* Note: Touch Y position from the device is inverted relative
> -- 
> 1.7.7.3
> 

    Acked-by: Henrik Rydberg <rydberg@...omail.se>

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/