linux-kernel - Re: error: implicit declarations of BUG/BUG_ON/WARN_ON/WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120625042017.GA11705@localhost>
Date:	Mon, 25 Jun 2012 12:20:17 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: error: implicit declarations of BUG/BUG_ON/WARN_ON/WARN_ON_ONCE

Hi Paul,

The patch builds fine, thank you!

Tested-by: Fengguang Wu <wfg@...ux.intel.com>

Thanks,
Fengguang

> I'm really starting to loathe this header. This should take care of it:
> 
> ---
> 
> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> index 506ec19..7d10f96 100644
> --- a/include/asm-generic/bug.h
> +++ b/include/asm-generic/bug.h
> @@ -3,10 +3,18 @@
>  
>  #include <linux/compiler.h>
>  
> +#ifdef CONFIG_GENERIC_BUG
> +#define BUGFLAG_WARNING		(1 << 0)
> +#define BUGFLAG_TAINT(taint)	(BUGFLAG_WARNING | ((taint) << 8))
> +#define BUG_GET_TAINT(bug)	((bug)->flags >> 8)
> +#endif
> +
> +#ifndef __ASSEMBLY__
> +#include <linux/kernel.h>
> +
>  #ifdef CONFIG_BUG
>  
>  #ifdef CONFIG_GENERIC_BUG
> -#ifndef __ASSEMBLY__
>  struct bug_entry {
>  #ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS
>  	unsigned long	bug_addr;
> @@ -23,17 +31,8 @@ struct bug_entry {
>  #endif
>  	unsigned short	flags;
>  };
> -#endif		/* __ASSEMBLY__ */
> -
> -#define BUGFLAG_WARNING		(1 << 0)
> -#define BUGFLAG_TAINT(taint)	(BUGFLAG_WARNING | ((taint) << 8))
> -#define BUG_GET_TAINT(bug)	((bug)->flags >> 8)
> -
>  #endif	/* CONFIG_GENERIC_BUG */
>  
> -#ifndef __ASSEMBLY__
> -#include <linux/kernel.h>
> -
>  /*
>   * Don't use BUG() or BUG_ON() unless there's really no way out; one
>   * example might be detecting data structure corruption in the middle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/