linux-kernel - Re: [PATCH] drivers: staging: android: fix binder.c printk macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120625171715.GA29309@kroah.com>
Date:	Mon, 25 Jun 2012 10:17:15 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sherwin Soltani <sherwin@...c.com>
Cc:	swetland@...gle.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: android: fix binder.c printk macros

On Sat, Jun 23, 2012 at 02:09:41AM -0400, Sherwin Soltani wrote:
> Changed to pr_warn, pr_err, and pr_info macros and reformatted some
> lines to bring them under the 80 column limit in the binder.c code.
> 
> Signed-off-by: Sherwin Soltani <sherwin@...c.com>
> ---
>  drivers/staging/android/binder.c |   74 ++++++++++++++++++++------------------
>  1 file changed, 40 insertions(+), 34 deletions(-)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

---   Your patch did many different things all at once, making it
      difficult to review.  All Linux kernel patches need to only do one
      thing at a time.  If you need to do multiple things (such as clean
      up all coding style issues in a file/driver), do it in a sequence
      of patches, each one doing only one thing.  This will make it
      easier to review the patches to ensure that they are correct, and
      to help alleviate any merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/