linux-kernel - Re: [PATCH] drivers: staging: android: fix binder.c printk macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120625174514.GA3676@kroah.com>
Date:	Mon, 25 Jun 2012 10:45:14 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	devel@...verdev.osuosl.org, swetland@...gle.com,
	Sherwin Soltani <sherwin@...c.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: android: fix binder.c printk macros

On Mon, Jun 25, 2012 at 10:30:08AM -0700, Joe Perches wrote:
> On Mon, 2012-06-25 at 10:24 -0700, Greg KH wrote:
> > On Mon, Jun 25, 2012 at 10:20:00AM -0700, Joe Perches wrote:
> > > Your patch-bot needs work.
> > > 
> > > Converting printks to pr_<level> is trivial
> > > and should be done all at once, not piecemeal.
> > 
> > I'm not disagreeing with that, unfortunately this patch also did more
> > than just pr_<level> conversions, which is why my patch-bot kicked in.
> > 
> > So your patch-bot complaint generator needs work :)
> 
> Or not.  I think wholesale whitespace changes are just
> fine too.

That's nice, but you aren't the one accepting these patches, sorry.

Also, again, I don't want to see whitespace changes at the same time as
other changes like this, as it makes things harder to review.

> git diff -w can ignore all those things pretty easily.

Ok, but you can't "ignore" those changes before you apply them, which is
what I have to do in reviewing patches.

> Using a bot is certainly sensible and sanity-preserving.
> I think it just needs a little tweaking.

Again, the bot worked properly here, there was more than one logical
change in the patch, so it needs to be split up.  One for the pr_<level>
chanegs, and one for the "lines greater than 80 columns" changes.

If the bot annoys you so much, you can filter it away, or, if others
complain, I can have it not post to mailing lists and only respond to
the original author, but that's generally rude for having a
conversation.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/