linux-kernel - Re: [PATCH] spi: Unlock a spinlock before calling into the controller driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda5-6Lp74eqG1mw=VCeMx1GXN=24mw+oavFPMypz3TpEQ@mail.gmail.com>
Date:	Tue, 26 Jun 2012 03:01:58 +0800
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Bryan Freed <bfreed@...omium.org>
Cc:	spi-devel-general@...ts.sourceforge.net, grant.likely@...retlab.ca,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: Unlock a spinlock before calling into the controller driver.

On Sat, Jun 23, 2012 at 7:53 AM, Bryan Freed <bfreed@...omium.org> wrote:

> spi_pump_messages() calls into a controller driver with
> unprepare_transfer_hardware() which is documented as "This may sleep".
> As in the prepare_transfer_hardware() call below, we should release the
> queue_lock spinlock before making the call.
> Rework the logic a bit to hold queue_lock to protect the 'busy' flag,
> then release it to call unprepare_transfer_hardware().
>
> Signed-off-by: Bryan Freed <bfreed@...omium.org>

Yes, this looks correct to me! Good catch.
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/