linux-kernel - Re: [PATCH] gpiolib: Add support for Wolfson Microelectronics Arizona class devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbKyHtwcsGoph_s-YPtn9yUxxKQBfXc_ksiNu=yE51spA@mail.gmail.com>
Date:	Tue, 26 Jun 2012 03:13:58 +0800
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] gpiolib: Add support for Wolfson Microelectronics Arizona
 class devices

On Sat, Jun 23, 2012 at 8:29 PM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:

I'm uncertain when it comes to the semantics of these babies,
and can't really tell what's going on:

> +       return regmap_update_bits(arizona->regmap, ARIZONA_GPIO1_CTRL + offset,
> +                                 ARIZONA_GPN_DIR, ARIZONA_GPN_DIR);
(...)
> +       return regmap_update_bits(arizona->regmap, ARIZONA_GPIO1_CTRL + offset,
> +                                 ARIZONA_GPN_DIR | ARIZONA_GPN_LVL, value);
(...)
> +       regmap_update_bits(arizona->regmap, ARIZONA_GPIO1_CTRL + offset,
> +                          ARIZONA_GPN_LVL, value);

I'm guessing that regmap is caching, selectively updating volatile
regs and marshalling the writes in the background.

The rest looks simple and flawless, and of course I trust that you're
doing the right thing with regmap anyway so:
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/