linux-kernel - Re: [PATCH v3] printk: Have printk() never buffer its data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120625150722.8cd4f45d.akpm@linux-foundation.org>
Date:	Mon, 25 Jun 2012 15:07:22 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	"kay.sievers" <kay.sievers@...y.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Joe Perches <joe@...ches.com>,
	"Paul E. McKenney" <paulmck@...ibm.com>
Subject: Re: [PATCH v3] printk: Have printk() never buffer its data

On Mon, 25 Jun 2012 15:05:42 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> 
> This brings back the old way of printk() that always prints to the console
> and does not buffer the data. As printk_emit() is used by other 'facilities'
> this only affects printk(), but keeps pretty much the new behavior.

If you say so.  The core printk code is starting to make one think of
things like "cleansing with fire".

Why did that logging code need to futz with this printk behaviour in
the first place?

I don't think the thing which you're fixing here was a real
showstopper.  If a non-newline-terminated printk gets delayed, then so
be it - we identify and fix all callers and remember the new rule and
move on, although I still don't know why this change was deemed
necessary.  If that results in a cleaner, clearer and more reliable
core printk() then we win.

And we do need a cleaner, clearer and more reliable core printk() :(
wtf have you guys been up to??  

<wonders why vprintk_emit() is asmlinkage, global, exported to modules
and has no callers outside printk.c>

>	/* This stops the holder of console_sem just where we want him */

This poor comment is now stranded half a page away from the code it's
documenting.  Please check that it's still true and then relocate it?

>
> ...
>

must.. stop.. thinking.. about.. fire..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/