linux-kernel - Re: linux-next: build failure after merge of the sound-asoc tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jun 2012 11:39:30 +0530
From:	Rajeev kumar <rajeev-dlh.kumar@...com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the sound-asoc tree

Hi Stephen,

On 6/25/2012 9:41 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "clk_disable" [sound/soc/dwc/designware_i2s.ko] undefined!
> ERROR: "clk_get" [sound/soc/dwc/designware_i2s.ko] undefined!
> ERROR: "clk_enable" [sound/soc/dwc/designware_i2s.ko] undefined!
> ERROR: "clk_put" [sound/soc/dwc/designware_i2s.ko] undefined!

I have checked this on ARM platform where these definitions are 
available (clk_get/clk_put* variants are usually used by ARM platforms).

To ensure compilation does not fail on x86_64 we can do either of three 
things:

1. Protecting clk_get/clk_put* calls under macro 'CONFIG_HAVE_CLK' in 
the driver.

2. Adding a check in Kconfig for HAVE_CLK.
(But that will limit the compilation of this driver for only platforms 
which are ARM based/or similar).

3. We can pick the patches circulated by Viresh Kumar where we don't 
have HAVE_CLK defined for x86_64, then the inline routines like 
following should come into play:

static inline unsigned long clk_get_rate(struct clk *clk)
{
         return 0;
}

See the patches for the same here:
http://lkml.org/lkml/2012/4/24/154

Please let me know your opinion.

Best Regards
Rajeev

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/