linux-kernel - Re: [PATCH 1/2] regulator: core: Only delay if we successfully set the voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120626104028.GO30406@opensource.wolfsonmicro.com>
Date:	Tue, 26 Jun 2012 11:40:29 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: core: Only delay if we successfully set
 the voltage

On Tue, Jun 26, 2012 at 06:30:16PM +0800, Axel Lin wrote:

> >        /* Call set_voltage_time_sel if successfully obtained old_selector */
> > -       if (_regulator_is_enabled(rdev) && ret == 0 && old_selector >= 0 &&
>                                                                   ^^^^^^^^
>                                                                  We
> already check ret ==0 here.

Your mailer is seriously messing up your formatting - the indentation is
nothing to do with what you're trying to point at...

The checks do need to be reordered here, though - we should check the
return value first.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/