linux-kernel - [PATCH] mfd: MFD_MAX77686 needs to select REGMAP_I2C and IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340674008.2942.1.camel@phoenix>
Date:	Tue, 26 Jun 2012 09:26:48 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Chiwoong Byun <woong.byun@...sung.com>,
	Jonghwa Lee <jonghwa3.lee@...sung.com>,
	Myungjoo Ham <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Yadwinder Singh Brar <yadi.brar@...sung.com>,
	SamuelOrtiz <sameo@...ux.intel.com>
Subject: [PATCH] mfd: MFD_MAX77686 needs to select REGMAP_I2C and IRQ_DOMAIN

Select REGMAP_I2C to fix below build errors:

  CC      drivers/mfd/max77686.o
drivers/mfd/max77686.c:43:15: error: variable 'max77686_regmap_config' has initializer but incomplete type
drivers/mfd/max77686.c:44:2: error: unknown field 'reg_bits' specified in initializer
drivers/mfd/max77686.c:44:2: warning: excess elements in struct initializer [enabled by default]
drivers/mfd/max77686.c:44:2: warning: (near initialization for 'max77686_regmap_config') [enabled by default]
drivers/mfd/max77686.c:45:2: error: unknown field 'val_bits' specified in initializer
drivers/mfd/max77686.c:45:2: warning: excess elements in struct initializer [enabled by default]
drivers/mfd/max77686.c:45:2: warning: (near initialization for 'max77686_regmap_config') [enabled by default]
drivers/mfd/max77686.c: In function 'max77686_i2c_probe':
drivers/mfd/max77686.c:60:2: error: implicit declaration of function 'regmap_init_i2c' [-Werror=implicit-function-declaration]
drivers/mfd/max77686.c:60:19: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mfd/max77686.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2

Select IRQ_DOMAIN to fix below build errors:

  CC      drivers/mfd/max77686-irq.o
drivers/mfd/max77686-irq.c: In function 'max77686_irq_thread':
drivers/mfd/max77686-irq.c:213:4: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
drivers/mfd/max77686-irq.c: In function 'max77686_irq_init':
drivers/mfd/max77686-irq.c:282:2: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
drivers/mfd/max77686-irq.c:282:9: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mfd/max77686-irq.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <axel.lin@...il.com>
---
 drivers/mfd/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 3b59661..a7d0c85 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -426,6 +426,8 @@ config MFD_MAX77686
 	bool "Maxim Semiconductor MAX77686 PMIC Support"
 	depends on I2C=y && GENERIC_HARDIRQS
 	select MFD_CORE
+	select REGMAP_I2C
+	select IRQ_DOMAIN
 	help
 	  Say yes here to support for Maxim Semiconductor MAX77686.
 	  This is a Power Management IC with RTC on chip.
-- 
1.7.9.5



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/