linux-kernel - Re: [RFC, PATCH] CLONE_NEWIPC and exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Jun 2012 17:55:14 +0000
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Dmitry V. Levin" <ldv@...linux.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Doug Ledford <dledford@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, serge@...lyn.com,
	"Kirill A. Shutemov" <kirill@...temov.name>
Subject: Re: [RFC, PATCH] CLONE_NEWIPC and exit_group()

Quoting Kirill A. Shutemov (kirill.shutemov@...ux.intel.com):
> On Tue, Jun 26, 2012 at 05:04:57PM +0000, Serge E. Hallyn wrote:
> > Quoting Kirill A. Shutemov (kirill.shutemov@...ux.intel.com):
> > > Hi,
> > > 
> > > Patch to move kern_unmount() out of exit_group() code path is below.
> > > Dmitry, could you check if it's beneficial for your use-case?
> > 
> > Hi,
> > 
> > sorry, I don't seem to have the thread handy for contest.  What is the
> > point of this?  The work being moved was not being done under lock,
> > so what is this meant to gain?
> 
> It's basically addition to this patch (tested with the patch applied):
> 
> http://thread.gmane.org/gmane.linux.kernel.cifs/6347/focus=23929
> 
> Some context: Dmitry has workload which run a lot of short-living tasks in
> sandboxed environment. He noticed that exit_group() syscall of the last
> process in IPC namespace is a bottleneck.
> 
> The bottleneck was mainly due rcu_barrier() in kern_umount(). It's fixed
> by patch in the link (Andrew took it in -mm).
> 

Ah I see, thanks.

> But probably having kern_umount() in exit_group() code path is not a good
> idea from scalability point of view?..

OTOH, does doing that mean that the extra processing time is (correctly)
accounted to the exiting user?  Just a thought.  But your argument also
makes sense, and I see no problem with the patch, so

Acked-by: Serge Hallyn <serge.hallyn@...ntu.com>

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/