[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120626203400.GA11413@one.firstfloor.org>
Date: Tue, 26 Jun 2012 22:34:00 +0200
From: Andi Kleen <andi@...stfloor.org>
To: Mel Gorman <mel@....ul.ie>
Cc: Andi Kleen <andi@...stfloor.org>,
Rafael Aquini <aquini@...hat.com>, linux-mm@...ck.org,
Rik van Riel <riel@...hat.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
linux-kernel@...r.kernel.org,
virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages
> How is the compiler meant to optimise away "cond" if it's a function
> call?
Inlines can be optimized away. These tests are usually inlines.
> What did I miss? If nothing, then I will revert this particular change
> and Rafael will need to be sure his patch is not using VM_BUG_ON to call
> a function with side-effects.
Do you have an example where the code is actually different,
or are you just speculating?
FWIW for my config both generates the same code:
size vmlinux-andi-vmbug vmlinux-vmbug-nothing
text data bss dec hex filename
11809704 1457352 1159168 14426224 dc2070 vmlinux-andi-vmbug
11809704 1457352 1159168 14426224 dc2070 vmlinux-vmbug-nothing
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists