linux-kernel - Re: [PATCH 3/9] arm/PCI: move final fixup quirks from __init to _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo5yNxjjBVaTXjAKCY4SfRWj7uXK2cS3BtkugmoF4fYn6g@mail.gmail.com>
Date:	Tue, 26 Jun 2012 16:33:12 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Myron Stowe <myron.stowe@...hat.com>
Cc:	linux-pci@...r.kernel.org, linux@....linux.org.uk,
	ralf@...ux-mips.org, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/9] arm/PCI: move final fixup quirks from __init to __devinit

On Thu, Jun 21, 2012 at 2:24 PM, Myron Stowe <myron.stowe@...hat.com> wrote:
> The PCI subsystem's final fixups are executed once during boot, after the
> pci-device is found.  As long as the system does not support hot-plug,
> specifying __init is fine.
>
> With hot-plug, either physically based hot-plug events or pseudo hot-plug
> events such as "echo 1 > /sys/bus/pci/rescan", it is possible to remove a
> PCI bus during run time and have it rediscovered which will require the
> call of the fixups again in order for the device to function properly.
>
> This patch prepares specific quirk(s) for use with hot-plug events.
>
> Signed-off-by: Myron Stowe <myron.stowe@...hat.com>
> ---
>
>  arch/arm/mach-iop32x/n2100.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-iop32x/n2100.c b/arch/arm/mach-iop32x/n2100.c
> index 5a7ae91..04c4110 100644
> --- a/arch/arm/mach-iop32x/n2100.c
> +++ b/arch/arm/mach-iop32x/n2100.c
> @@ -126,7 +126,7 @@ static struct hw_pci n2100_pci __initdata = {
>  * the ->broken_parity_status flag for both ports so that the r8169
>  * driver knows it should ignore error interrupts.
>  */
> -static void n2100_fixup_r8169(struct pci_dev *dev)
> +static void __devinit n2100_fixup_r8169(struct pci_dev *dev)

These actually move functions from normal text to __devinit, not from
__init to __devinit.

That should be safe for most quirks (although enable, suspend, resume,
and resume_early quirks can be called after we free initmem, even if
we have CONFIG_HOTPLUG=n), but given the discussion about whether we
should even bother with __devinit any more, I think I'll hold off on
these for now.  If we were to get rid of __devinit, these would all
have to revert to being normal text.

>  {
>        if (dev->bus->number == 0 &&
>            (dev->devfn == PCI_DEVFN(1, 0) ||
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/