linux-kernel - Re: [PATCH v2] memcg: unify mem_control_xxx to memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FEAC7C6.7030601@parallels.com>
Date:	Wed, 27 Jun 2012 12:43:50 +0400
From:	Glauber Costa <glommer@...allels.com>
To:	Wanpeng Li <liwp.linux@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Hocko <mhocko@...e.cz>,
	Johannes Weiner <hannes@...xchg.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Balbir Singh <bsingharora@...il.com>,
	<linux-kernel@...r.kernel.org>, <cgroups@...r.kernel.org>
Subject: Re: [PATCH v2] memcg: unify mem_control_xxx to memcg_xxx

On 06/27/2012 04:16 AM, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@...ux.vnet.ibm.com>
>
> Changelog:
>
> V2 -> V1:
>
> * replace memory_cgroup_xxx by memcg_xxx
>
> Unify memcg functions to memcg_xxx.

This patch achieves nothing.
You're changing a couple of function names. Andrew stated goal was to 
change *all* function names from mem_cgroup_xxx to memcg_xxx, not just 
one or two.

This can be done mechanically by replacing occurrences of mem_cgroup_xxx 
with memcg_xxx, and verifying that your final result is correct by 
compiling the kernel with and without the combination of config options 
that matters here, plus a set of randconfigs - or anything like that.

Make sure you have Andrew's latest patch in your tree, that converts the 
config option names.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/