linux-kernel - Re: [PATCH v6 1/5] powerpc/85xx: implement hardware timebase sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340797732.3732.46.camel@pasglop>
Date:	Wed, 27 Jun 2012 21:48:52 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Zhao Chenhui <chenhui.zhao@...escale.com>
Cc:	linuxppc-dev@...ts.ozlabs.org, scottwood@...escale.com,
	linux-kernel@...r.kernel.org, leoli@...escale.com
Subject: Re: [PATCH v6 1/5] powerpc/85xx: implement hardware timebase sync

On Wed, 2012-06-27 at 18:21 +0800, Zhao Chenhui wrote:
> > What's that CONFIG option for ?
> > 
> > Cheers,
> > Ben.
> 
> This option is to guard the timebase sync routines. It is selected
> when KEXEC or HOTPLUG_CPU is enabled on Freescale Book-E platforms.

Any reason not to just make it unconditional ? That sort of config
option tend to just confuse things and make bug reports harder to sort
out.... Also you decrease your test coverage.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/