linux-kernel - Re: [PATCH] UDF: Remove unnecessary variable "offset" from udf_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120627155230.GA5387@quack.suse.cz>
Date:	Wed, 27 Jun 2012 17:52:30 +0200
From:	Jan Kara <jack@...e.cz>
To:	Ashish Sangwan <ashishsangwan2@...il.com>
Cc:	Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org,
	Ashish Sangwan <ashish.sangwan2@...il.com>,
	Namjae Jeon <linkinjeon@...il.com>
Subject: Re: [PATCH] UDF: Remove unnecessary variable "offset" from
 udf_fill_inode

On Tue 26-06-12 19:33:11, Ashish Sangwan wrote:
> The variable "offset" is not needed. Remove it.
  Thanks. Merged.

								Honza

> 
> Signed-off-by: Ashish Sangwan <ashish.sangwan2@...il.com>
> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
> ---
>  fs/udf/inode.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index 873e1ba..fafaad7 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -1247,7 +1247,6 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh)
>  {
>  	struct fileEntry *fe;
>  	struct extendedFileEntry *efe;
> -	int offset;
>  	struct udf_sb_info *sbi = UDF_SB(inode->i_sb);
>  	struct udf_inode_info *iinfo = UDF_I(inode);
>  	unsigned int link_count;
> @@ -1359,7 +1358,6 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh)
>  		iinfo->i_lenEAttr = le32_to_cpu(fe->lengthExtendedAttr);
>  		iinfo->i_lenAlloc = le32_to_cpu(fe->lengthAllocDescs);
>  		iinfo->i_checkpoint = le32_to_cpu(fe->checkpoint);
> -		offset = sizeof(struct fileEntry) + iinfo->i_lenEAttr;
>  	} else {
>  		inode->i_blocks = le64_to_cpu(efe->logicalBlocksRecorded) <<
>  		    (inode->i_sb->s_blocksize_bits - 9);
> @@ -1381,8 +1379,6 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh)
>  		iinfo->i_lenEAttr = le32_to_cpu(efe->lengthExtendedAttr);
>  		iinfo->i_lenAlloc = le32_to_cpu(efe->lengthAllocDescs);
>  		iinfo->i_checkpoint = le32_to_cpu(efe->checkpoint);
> -		offset = sizeof(struct extendedFileEntry) +
> -							iinfo->i_lenEAttr;
>  	}
>  
>  	switch (fe->icbTag.fileType) {
> -- 
> 1.7.2.3
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/